Skip to content
This repository has been archived by the owner on Apr 26, 2021. It is now read-only.

[DO NOT MERGE] CCD in prevention mode #38

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

[DO NOT MERGE] CCD in prevention mode #38

wants to merge 13 commits into from

Conversation

smathangi
Copy link

added excluded rules based on analysis of ccd prod in detection mode (1 week detection data)
https://tools.hmcts.net/jira/browse/RDM-3807

Copy link
Member

@cakeben cakeben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the changes but this should not be merged to master it should go on a different branch of the module which CCD should then seek to obtain sign off from SecOps before rolling out the change

Copy link

@mario-paniccia mario-paniccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mario-paniccia
Copy link

mario-paniccia commented Sep 16, 2019

I approve the changes but this should not be merged to master it should go on a different branch of the module which CCD should then seek to obtain sign off from SecOps before rolling out the change

I seems clear to me that CCD needs to run with custom exclusion rules. I think it'll make sense for the cnp-module-waf module on master branch support allowing setting custom exclusion rules. Until we have that, we'll always need to be on the ccd-waf branch, which is not that good.

@timja
Copy link
Contributor

timja commented Sep 16, 2019

I approve the changes but this should not be merged to master it should go on a different branch of the module which CCD should then seek to obtain sign off from SecOps before rolling out the change

I seems clear to me that CCD needs to run with custom exclusion rules. I think it'll make sense for the cnp-module-waf module on master branch support allowing setting custom exclusion rules. Until we have that, we'll always need to be on the ccd-waf branch, which is not that good.

correct we haven't invested in this though as we plan to move away from application gateway and use front door instead which supports application waf profiles in a much better way

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants