-
Notifications
You must be signed in to change notification settings - Fork 1
[DO NOT MERGE] CCD in prevention mode #38
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve the changes but this should not be merged to master it should go on a different branch of the module which CCD should then seek to obtain sign off from SecOps before rolling out the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I seems clear to me that CCD needs to run with custom exclusion rules. I think it'll make sense for the |
correct we haven't invested in this though as we plan to move away from application gateway and use front door instead which supports application waf profiles in a much better way |
RDM-6863-disableRules-RDM-6863
Remove offending duplicate rule
Previously using `equals` to test for existence of field, switched to using `contains` which is correct test. https://docs.microsoft.com/en-gb/azure/azure-resource-manager/templates/template-functions-array#contains
Add conditional request timeout property
RDM-7904-disable-942300-933160
added excluded rules based on analysis of ccd prod in detection mode (1 week detection data)
https://tools.hmcts.net/jira/browse/RDM-3807