Skip to content

Commit

Permalink
DL-14140 updating SCA Wrapper
Browse files Browse the repository at this point in the history
  • Loading branch information
AhmadZNaeem committed Jul 5, 2024
1 parent eb81041 commit 167490c
Show file tree
Hide file tree
Showing 16 changed files with 28 additions and 64 deletions.
3 changes: 0 additions & 3 deletions app/config/FrontendAppConfig.scala
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,7 @@
package config

import com.google.inject.{Inject, Singleton}
import controllers.routes
import play.api.Configuration
import play.api.i18n.Lang
import play.api.mvc.Call
import uk.gov.hmrc.play.bootstrap.config.ServicesConfig

@Singleton
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ package controllers.actions

import com.google.inject.Inject
import config.FrontendAppConfig
import controllers.routes._
import models.requests.IdentifierRequest
import play.api.Logging
import play.api.mvc.Results._
Expand Down
7 changes: 3 additions & 4 deletions app/controllers/actions/DataRequiredAction.scala
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,17 @@

package controllers.actions

import controllers.routes
import controllers.confirmation.{routes => confRoutes}
import controllers.routes
import models.NormalMode

import javax.inject.Inject
import models.requests.{DataRequest, OptionalDataRequest}
import navigation.{AuthenticatedNavigator, Navigator}
import navigation.AuthenticatedNavigator
import pages.SubmittedClaim
import pages.authenticated.Submission
import play.api.mvc.Results.Redirect
import play.api.mvc.{ActionRefiner, Result}

import javax.inject.Inject
import scala.concurrent.{ExecutionContext, Future}

class DataRequiredActionImpl @Inject()(navigator: AuthenticatedNavigator)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,19 @@
package controllers.confirmation

import controllers.actions.{AuthenticatedIdentifierAction, DataRequiredAction, DataRetrievalAction}
import controllers.routes.{SessionExpiredController, _}

import javax.inject.Inject
import controllers.routes._
import models.TaxYearSelection.CurrentYear
import models.{Address, FlatRateExpenseAmounts, Rates, TaiTaxYear, TaxYearSelection}
import pages.authenticated.{TaxYearSelectionPage, YourEmployerPage}
import pages.{CitizenDetailsAddress, ClaimAmountAndAnyDeductions, FREAmounts, FREResponse}
import play.api.Logging
import play.api.i18n.{I18nSupport, MessagesApi}
import play.api.mvc.{Action, AnyContent, MessagesControllerComponents}
import repositories.SessionRepository
import service.{ClaimAmountService, TaiService}
import uk.gov.hmrc.play.bootstrap.frontend.controller.FrontendBaseController
import views.html.confirmation.ConfirmationCurrentAndPreviousYearsView

import javax.inject.Inject
import scala.concurrent.{ExecutionContext, Future}

class ConfirmationCurrentAndPreviousYearsController @Inject()(override val messagesApi: MessagesApi,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,18 @@ package controllers.confirmation

import controllers.actions.{AuthenticatedIdentifierAction, DataRequiredAction, DataRetrievalAction}
import controllers.routes._

import javax.inject.Inject
import models.TaxYearSelection.CurrentYear
import models.{Address, FlatRateExpenseAmounts, Rates, TaiTaxYear, TaxYearSelection}
import pages.authenticated.YourEmployerPage
import pages.{CitizenDetailsAddress, ClaimAmountAndAnyDeductions, FREAmounts, FREResponse}
import play.api.Logging
import play.api.i18n.{I18nSupport, MessagesApi}
import play.api.mvc.{Action, AnyContent, MessagesControllerComponents}
import repositories.SessionRepository
import service.{ClaimAmountService, TaiService}
import uk.gov.hmrc.play.bootstrap.frontend.controller.FrontendBaseController
import views.html.confirmation.ConfirmationCurrentYearOnlyView

import javax.inject.Inject
import scala.concurrent.{ExecutionContext, Future}

class ConfirmationCurrentYearOnlyController @Inject()(override val messagesApi: MessagesApi,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,15 @@ import controllers.actions.{AuthenticatedIdentifierAction, DataRequiredAction, D
import controllers.routes.SessionExpiredController
import models.NormalMode
import navigation.Navigator
import pages.{ClaimAmountAndAnyDeductions, FREResponse}
import pages.authenticated.{TaxYearSelectionPage, YourEmployerPage}
import pages.confirmation.ConfirmationMergeJourneyPage
import pages.{ClaimAmountAndAnyDeductions, FREResponse}
import play.api.i18n.{I18nSupport, MessagesApi}
import play.api.mvc.{Action, AnyContent, MessagesControllerComponents}
import uk.gov.hmrc.play.bootstrap.frontend.controller.FrontendBaseController
import views.html.confirmation.ConfirmationMergeJourneyView

import javax.inject.{Inject, Named}
import scala.concurrent.Future

class ConfirmationMergeJourneyController @Inject()(
override val messagesApi: MessagesApi,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,20 +17,18 @@
package controllers.confirmation

import controllers.actions.{AuthenticatedIdentifierAction, DataRequiredAction, DataRetrievalAction}
import controllers.routes.{SessionExpiredController, _}

import javax.inject.Inject
import controllers.routes._
import models.{Address, Rates, TaiTaxYear, TaxYearSelection}
import pages.authenticated.TaxYearSelectionPage
import pages.{CitizenDetailsAddress, ClaimAmountAndAnyDeductions, FREResponse}
import play.api.Logging
import play.api.i18n.{I18nSupport, MessagesApi}
import play.api.mvc.{Action, AnyContent, MessagesControllerComponents}
import repositories.SessionRepository
import service.{ClaimAmountService, TaiService}
import uk.gov.hmrc.play.bootstrap.frontend.controller.FrontendBaseController
import views.html.confirmation.ConfirmationPreviousYearsOnlyView

import javax.inject.Inject
import scala.concurrent.{ExecutionContext, Future}

class ConfirmationPreviousYearsOnlyController @Inject()(override val messagesApi: MessagesApi,
Expand Down
4 changes: 2 additions & 2 deletions app/views/LayoutProvider.scala
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import play.api.i18n.Messages
import play.api.mvc.Request
import play.twirl.api.{Html, HtmlFormat}
import uk.gov.hmrc.hmrcfrontend.views.viewmodels.hmrcstandardpage.ServiceURLs
import uk.gov.hmrc.play.http.HeaderCarrierConverter
import uk.gov.hmrc.sca.services.WrapperService
import views.html.playComponents.{AdditionalScript, HeadBlock}

Expand Down Expand Up @@ -83,6 +82,7 @@ class NewLayoutProvider @Inject()(wrapperService: WrapperService,
pageTitle = Some(s"$pageTitle - ${messages(serviceNameKeyOverride.getOrElse("service.name"))} - GOV.UK"),
serviceNameKey = Some(serviceNameKeyOverride.getOrElse("service.name")),
serviceURLs = ServiceURLs(
signOutUrl = Some(controllers.authenticated.routes.SignOutController.signOut.url),
serviceUrl = Some(serviceUrlOverride.getOrElse(controllers.routes.IndexController.start.url))
),
timeOutUrl = Some(controllers.authenticated.routes.SignOutController.signOut.url),
Expand All @@ -92,6 +92,6 @@ class NewLayoutProvider @Inject()(wrapperService: WrapperService,
styleSheets = stylesheets.toSeq :+ headBlock(),
fullWidth = false,
hideMenuBar = hideAccountMenu,
)(messages, HeaderCarrierConverter.fromRequest(request), request)
)(messages, request)
}
}
2 changes: 1 addition & 1 deletion app/views/authenticated/CheckYourAnswersView.scala.html
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ <h2 class="govuk-heading-m">@messages(s"checkYourAnswers.${checkYourAnswersText.
<div class="govuk-warning-text">
<span class="govuk-warning-text__icon" aria-hidden="true">!</span>
<strong class="govuk-warning-text__text">
<span class="govuk-warning-text__assistive">>@messages("checkYourAnswers.warning")</span>
<span class="govuk-warning-text__assistive">@messages("checkYourAnswers.warning")</span>
@messages("checkYourAnswers.prosecuted")
</strong>
</div>
Expand Down
14 changes: 0 additions & 14 deletions conf/application-json-logger.xml

This file was deleted.

12 changes: 1 addition & 11 deletions conf/application.conf
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ play.http.filters = "config.Filters"
# ~~~~
# Additional play modules can be added here
play.modules.enabled += "uk.gov.hmrc.play.bootstrap.HttpClientModule"
play.modules.enabled += "uk.gov.hmrc.play.bootstrap.HttpClientV2Module"
play.modules.enabled += "uk.gov.hmrc.play.bootstrap.AuthModule"
play.modules.enabled += "config.Module"
play.modules.enabled += "uk.gov.hmrc.mongo.play.PlayMongoModule"
Expand Down Expand Up @@ -212,12 +213,7 @@ feature-switch {
sca-wrapper {
host = "http://localhost:9334"
service.url = "http://localhost:9334/employee-expenses"
feedback-service-name = "employee-expenses-frontend"
exit-survey-origin = "employee-expenses"
accessibility-statement {
referrer.url = "/employee-expenses"
redirect.url = "employee-expenses"
}
service-name {
messages-key = service.name
}
Expand All @@ -227,16 +223,10 @@ sca-wrapper {
timeout = 900
countdown = 120
}
signout {
url = "/employee-expenses/sign-out"
alternative-url = null
}
services {
tracking-frontend.url = "http://localhost:9100"
feedback-frontend.url = "http://localhost:9514"
contact-frontend.url = "http://localhost:9250"
pertax-frontend.url = "http://localhost:9232"
accessibility-statement-frontend.url = "http://localhost:12346"
single-customer-account-wrapper-data.url = "http://localhost:8422"
}
banners {
Expand Down
8 changes: 4 additions & 4 deletions project/AppDependencies.scala
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@ import sbt.*

object AppDependencies {

private val mongoVersion = "1.7.0"
private val bootstrapVersion = "8.4.0"
private val mongoVersion = "2.1.0"
private val bootstrapVersion = "9.0.0"

val compile: Seq[ModuleID] = Seq(
play.sbt.PlayImport.ws,
"uk.gov.hmrc.mongo" %% "hmrc-mongo-play-30" % mongoVersion,
"uk.gov.hmrc" %% "play-conditional-form-mapping-play-30" % "2.0.0",
"uk.gov.hmrc" %% "tax-year" % "4.0.0",
"uk.gov.hmrc" %% "sca-wrapper-play-30" % "1.3.0"
"uk.gov.hmrc" %% "tax-year" % "5.0.0",
"uk.gov.hmrc" %% "sca-wrapper-play-30" % "1.9.0"
)


Expand Down
4 changes: 2 additions & 2 deletions project/plugins.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ resolvers += Resolver.typesafeRepo("releases")

addSbtPlugin("uk.gov.hmrc" % "sbt-auto-build" % "3.22.0")
addSbtPlugin("uk.gov.hmrc" % "sbt-distributables" % "2.5.0")
addSbtPlugin("org.playframework" % "sbt-plugin" % "3.0.1")
addSbtPlugin("org.playframework" % "sbt-plugin" % "3.0.4")
addSbtPlugin("org.scalastyle" %% "scalastyle-sbt-plugin" % "1.0.0" exclude("org.scala-lang.modules", "scala-xml_2.12"))
addSbtPlugin("org.scoverage" % "sbt-scoverage" % "2.0.9")
addSbtPlugin("org.scoverage" % "sbt-scoverage" % "2.0.12")
Original file line number Diff line number Diff line change
Expand Up @@ -142,21 +142,21 @@ class ConfirmationCurrentAndPreviousYearsViewSpec extends ViewBehaviours {

val doc = asDocument(applyView(freResponse = FlatRateExpenseOptions.FRESomeYears)(fakeRequest, messages))

doc.getElementsByTag("title").text mustBe "Claim changed - Claim for your work uniform and tools - GOV.UK"
doc.title mustBe "Claim changed - Claim for your work uniform and tools - GOV.UK"
}

"display correct title when freResponse is 'FREAllYearsAllAmountsSameAsClaimAmount'" in {

val doc = asDocument(applyView(freResponse = FlatRateExpenseOptions.FREAllYearsAllAmountsSameAsClaimAmount)(fakeRequest, messages))

doc.getElementsByTag("title").text mustBe "Claim changed - Claim for your work uniform and tools - GOV.UK"
doc.title mustBe "Claim changed - Claim for your work uniform and tools - GOV.UK"
}

"display correct title when freResponse is 'FRENoYears'" in {

val doc = asDocument(applyView(freResponse = FlatRateExpenseOptions.FRENoYears)(fakeRequest, messages))

doc.getElementsByTag("title").text mustBe "Claim complete for uniform, work clothing and tools - Claim for your work uniform and tools - GOV.UK"
doc.title mustBe "Claim complete for uniform, work clothing and tools - Claim for your work uniform and tools - GOV.UK"
}

"YourAddress" must {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,21 +166,21 @@ class ConfirmationCurrentYearOnlyViewSpec extends ViewBehaviours {

val doc = asDocument(applyView(freResponse = FlatRateExpenseOptions.FRESomeYears)(fakeRequest, messages))

doc.getElementsByTag("title").text mustBe "Claim changed - Claim for your work uniform and tools - GOV.UK"
doc.title mustBe "Claim changed - Claim for your work uniform and tools - GOV.UK"
}

"display correct title when freResponse is 'FREAllYearsAllAmountsSameAsClaimAmount'" in {

val doc = asDocument(applyView(freResponse = FlatRateExpenseOptions.FREAllYearsAllAmountsSameAsClaimAmount)(fakeRequest, messages))

doc.getElementsByTag("title").text mustBe "Claim changed - Claim for your work uniform and tools - GOV.UK"
doc.title mustBe "Claim changed - Claim for your work uniform and tools - GOV.UK"
}

"display correct title when freResponse is 'FRENoYears'" in {

val doc = asDocument(applyView(freResponse = FlatRateExpenseOptions.FRENoYears)(fakeRequest, messages))

doc.getElementsByTag("title").text mustBe "Claim complete for uniform, work clothing and tools - Claim for your work uniform and tools - GOV.UK"
doc.title mustBe "Claim complete for uniform, work clothing and tools - Claim for your work uniform and tools - GOV.UK"
}

"YourAddress" must {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,21 +100,21 @@ class ConfirmationPreviousYearsOnlyViewSpec extends ViewBehaviours {

val doc = asDocument(applyView(freResponse = FlatRateExpenseOptions.FRESomeYears)(fakeRequest, messages))

doc.getElementsByTag("title").text mustBe "Claim changed - Claim for your work uniform and tools - GOV.UK"
doc.title mustBe "Claim changed - Claim for your work uniform and tools - GOV.UK"
}

"display correct title when freResponse is 'FREAllYearsAllAmountsSameAsClaimAmount'" in {

val doc = asDocument(applyView(freResponse = FlatRateExpenseOptions.FREAllYearsAllAmountsSameAsClaimAmount)(fakeRequest, messages))

doc.getElementsByTag("title").text mustBe "Claim changed - Claim for your work uniform and tools - GOV.UK"
doc.title mustBe "Claim changed - Claim for your work uniform and tools - GOV.UK"
}

"display correct title when freResponse is 'FRENoYears'" in {

val doc = asDocument(applyView(freResponse = FlatRateExpenseOptions.FRENoYears)(fakeRequest, messages))

doc.getElementsByTag("title").text mustBe "Claim complete for uniform, work clothing and tools - Claim for your work uniform and tools - GOV.UK"
doc.title mustBe "Claim complete for uniform, work clothing and tools - Claim for your work uniform and tools - GOV.UK"
}

"YourAddress" must {
Expand Down

0 comments on commit 167490c

Please sign in to comment.