Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DL-5855: Upgrade #414

Merged
merged 1 commit into from
Aug 31, 2022
Merged

DL-5855: Upgrade #414

merged 1 commit into from
Aug 31, 2022

Conversation

selinahussain
Copy link
Contributor

JIRA Story or Github Number - descriptive title

Bug fix / New feature (delete as appropriate)

Please include a summary / description of the change and which issue it fixes. Include any relevant user needs, context or links to other PRs related to this PR (eg. acceptance tests, environment config).

Checklist

Reviewee (Replace with your name)

  • I've made every effort to commit high quality, clean code and I have executed relevant static analyses to be sure
  • I've included appropriate tests with any code I've added (Unit, Integration, Acceptance etc.)
  • I've executed the acceptance test pack locally to ensure there are no functional regressions
  • I've added my code using logical, atomic commits, squashing as appropriate - including the JIRA issue number in the commit message
  • I've run a dependency check to ensure all dependencies are up to date

Reviewer (Replace with your name)

  • I've confirmed that every effort has been made to commit high quality, clean code and I have executed relevant static analyses to be sure
  • I've confirmed appropriate tests has been included with any code added (Unit, Integration, Acceptance etc.)
  • I've executed the acceptance test pack locally to ensure there are no functional regressions
  • I've confirmed code was added using logical, atomic commits, squashing as appropriate - including the JIRA issue number in the commit message
  • I've run a dependency check to ensure all dependencies are up to date

@selinahussain selinahussain merged commit 30881f1 into main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants