Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve reading order and region order #44

Merged
merged 2 commits into from
May 24, 2022

Conversation

bertsky
Copy link
Contributor

@bertsky bertsky commented May 21, 2022

Fixes #42

Fixes regarding reading order:

  • all region types that are in ReadingOrder should get arrows (i.e. no classes filter)
  • no region types that are not in ReadingOrder should get arrows (i.e. reading-order-only instead of reading-order)

Fixes regarding rendering order:

  • separators should always stay above other regions
  • text regions should stay above other regions, but below separators

@hnesk hnesk merged commit 98c4f30 into hnesk:master May 24, 2022
@hnesk
Copy link
Owner

hnesk commented May 24, 2022

Thanks @bertsky ! I just merged it, but out of curiosity, do you have an example Page-XML for the problem? Maybe there is an even simpler solution.

@bertsky
Copy link
Contributor Author

bertsky commented May 24, 2022

Yes, I'll send you one (lots of tables with recursive cells but also separators) later in the day.

@bertsky
Copy link
Contributor Author

bertsky commented Jun 9, 2022

Yes, I'll send you one (lots of tables with recursive cells but also separators) later in the day.

Here it is: Gutachten2-2.zip

(The data is pseudo-text, no privacy concerns.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ViewPage: ReadingOrder display ignores tables
2 participants