Dockerfile: use local pkg, not PyPI #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: CI failure is not related, but due to OCR-D/core#957 |
kba
approved these changes
Dec 1, 2022
|
@hnesk this is becoming quite urgent now. We have not only the importlib_metadata incompatibility, but now also numpy 1.24 is out breaking things like So we cannot install via PyPI, and we cannot build from Docker (without merging this PR first/locally). |
|
@bertsky I'm really sorry that took so long, I had dayjob stuff to do and a broken ocrd/python/os-environment. |
|
@hnesk much obliged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the current Docker build, which currently still runs into the problem fixed by #53 – because the build used to install ocrd_browser via PyPI instead of the locally checked out sources, and there has not been a new PyPI release since 0.5.3. (So this affected both the Dockerhub images and the local build.)