Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve types and undo #240 #252

Merged
merged 9 commits into from
Aug 17, 2020
Merged

Improve types and undo #240 #252

merged 9 commits into from
Aug 17, 2020

Conversation

hoangvvo
Copy link
Owner

@hoangvvo hoangvvo commented Aug 17, 2020

This allows calling applySession, withSession, and session with a generic that represents the shape of req.session.

Also undo #240 become it is quite problematic. (user wants to committed but then mutate and committed again)

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #252 into master will decrease coverage by 0.77%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
- Coverage   95.34%   94.57%   -0.78%     
==========================================
  Files           9        9              
  Lines         172      166       -6     
  Branches       46       50       +4     
==========================================
- Hits          164      157       -7     
  Misses          2        2              
- Partials        6        7       +1     
Impacted Files Coverage Δ
src/types.ts 100.00% <ø> (ø)
src/connect.ts 100.00% <100.00%> (ø)
src/core.ts 93.33% <100.00%> (-3.22%) ⬇️
src/session.ts 90.00% <100.00%> (-1.90%) ⬇️
src/withSession.ts 83.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86c6b39...2e7b046. Read the comment docs.

@hoangvvo hoangvvo changed the title Improve types Improve types and undo #240 Aug 17, 2020
@hoangvvo hoangvvo merged commit 214319a into master Aug 17, 2020
@hoangvvo hoangvvo deleted the improve-types branch September 22, 2021 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant