-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the need to use promisifyStore and refactor #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoangvvo
changed the title
Remove the need to use promisifyStore
Remove the need to use promisifyStore and refactor
Aug 30, 2020
hoangvvo
force-pushed
the
without-promisify-store
branch
from
August 31, 2020 06:54
4b30a66
to
3589dcb
Compare
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
==========================================
+ Coverage 95.80% 96.44% +0.64%
==========================================
Files 9 7 -2
Lines 167 169 +2
Branches 48 50 +2
==========================================
+ Hits 160 163 +3
+ Misses 2 1 -1
Partials 5 5
Continue to review full report at Codecov.
|
hoangvvo
force-pushed
the
without-promisify-store
branch
from
August 31, 2020 07:45
1b183a7
to
2a45fa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.