Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need to use promisifyStore and refactor #257

Merged
merged 21 commits into from
Aug 31, 2020

Conversation

hoangvvo
Copy link
Owner

No description provided.

@hoangvvo hoangvvo changed the title Remove the need to use promisifyStore Remove the need to use promisifyStore and refactor Aug 30, 2020
@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #257 into master will increase coverage by 0.64%.
The diff coverage is 96.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   95.80%   96.44%   +0.64%     
==========================================
  Files           9        7       -2     
  Lines         167      169       +2     
  Branches       48       50       +2     
==========================================
+ Hits          160      163       +3     
+ Misses          2        1       -1     
  Partials        5        5              
Impacted Files Coverage Δ
src/types.ts 100.00% <ø> (ø)
src/core.ts 96.59% <96.15%> (-3.41%) ⬇️
src/compat.ts 100.00% <100.00%> (+5.00%) ⬆️
src/connect.ts 100.00% <100.00%> (ø)
src/store/memory.ts 100.00% <100.00%> (ø)
src/withSession.ts 83.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 424931f...1299968. Read the comment docs.

@hoangvvo hoangvvo merged commit 70e3e9d into master Aug 31, 2020
@hoangvvo hoangvvo deleted the without-promisify-store branch August 31, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant