Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty bookmark #225

Closed
arobase-che opened this issue Jun 14, 2024 · 1 comment
Closed

Empty bookmark #225

arobase-che opened this issue Jun 14, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@arobase-che
Copy link

Hello,

What about empty bookmark?
I have the feeling that I should not be able to « Save » an empty bookmark.
Maybe the Save button and ||Ctrl|| + ||Enter|| should be disabled when the « New item » textbox is empty?

Or maybe en empty bookmark should not be processed and early discarded ?

Thank you
@MohamedBassem MohamedBassem added the bug Something isn't working label Jun 14, 2024
@MohamedBassem
Copy link
Collaborator

This is good call. We shouldn't allow empty bookmarks :)

kamtschatka added a commit to kamtschatka/hoarder-app that referenced this issue Jun 15, 2024
@kamtschatka
Empty bookmark hoarder-app#225
162a8a5 
preventing the creation of empty bookmarks in the UI and the rest api
updated gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arobase-che @MohamedBassem