Any plans to support copy to clipboard (markdown code) for notes? #195 #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rder-app#195 added a button to copy the markdown and added code highlighting
| @@ -45,18 +45,15 @@ export default function TextCard({ | |||
|
|
|||
| return ( | |||
| <> | |||
| {/* TODO: Where is that used? Is it simply unused?*/} | |||
There was a problem hiding this comment.
This is the bookmark card shown in the BookmarkGrid.
There was a problem hiding this comment.
the thing is, if I remove the BookmarkedTextViewer, nothing changes, so I am not quite sure what it does?
Hovering the element in the React Extension does not highlight it either and previewModalOpen is only bound to this component, nothing else, so I don't think that value can actually change?
| code({ className, children, ...props }) { | ||
| const match = /language-(\w+)/.exec(className ?? ""); | ||
| return match ? ( | ||
| // @ts-expect-error i have absolutely no idea what it complains about and passing refs to it also does not solve it |
There was a problem hiding this comment.
What is the error you're getting?
There was a problem hiding this comment.
Types of property ref are incompatible.
Type LegacyRef<HTMLElement> | undefined is not assignable to type LegacyRef<SyntaxHighlighter> | undefined
Types of property ref are incompatible.
Type LegacyRef<HTMLElement> | undefined is not assignable to type LegacyRef<SyntaxHighlighter> | undefined
Type (instance: HTMLElement | null) => void is not assignable to type LegacyRef<SyntaxHighlighter> | undefined
Type (instance: HTMLElement | null) => void is not assignable to type (instance: SyntaxHighlighter | null) => void
Types of parameters instance and instance are incompatible.
Type SyntaxHighlighter | null is not assignable to type HTMLElement | null
Type Component<SyntaxHighlighterProps, {}, any> is missing the following properties from type HTMLElement:
accessKey, accessKeyLabel, autocapitalize, dir
, and 290 more.
…rder-app#195 Changed the copy-button to a generic one added a safeguard and a message to the copy button if copying is not possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a button to copy the markdown and added code highlighting
1 component seems unused
I am not sure how to test the mobile version/if that should also use the new component