Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Enhance the bookmark textarea in the list layout #247

Merged
merged 5 commits into from
Jun 22, 2024

Conversation

AhmadMuj
Copy link
Contributor

This PR contains 2 fixes:
1- Allow resizing the textfield in the list layout only, it does not break the UI and it gives a better experince when writing notes because the area for writing in the list mode is so small
2- Auto resizing the textfield to fit the content to a max of half the screen height

Copy link
Collaborator

@MohamedBassem MohamedBassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good to me. I think the only caveat is that we need to reset the size after the form is submitted somehow. Not sure what's the best way to do this though.

@AhmadMuj
Copy link
Contributor Author

I think now it's good to go @MohamedBassem

@MohamedBassem MohamedBassem merged commit ac05ecf into hoarder-app:main Jun 22, 2024
3 checks passed
@MohamedBassem
Copy link
Collaborator

Looks amazing, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants