refactoring asset types #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted out functions to silently delete assets and to update them after crawling Generalized the mapping of assets to bookmark fields to make extending them easier
packages/shared/assetdb.ts
Outdated
| */ | ||
| export async function silentDeleteAsset( | ||
| userId: string, | ||
| assetId: string | undefined, |
There was a problem hiding this comment.
Tbh, not convinced that an API in assetdb that's called silentDeleteAsset accepts an optional assetId. If we really care about this, I'd move it as a helper function in crawlerWorker. Not sure it's worth it.
apps/workers/crawlerWorker.ts
Outdated
| @@ -5,9 +5,11 @@ import type { Job } from "bullmq"; | |||
| import type { Browser } from "puppeteer"; | |||
| import { Readability } from "@mozilla/readability"; | |||
| import { Mutex } from "async-mutex"; | |||
| import Database from "better-sqlite3"; | |||
There was a problem hiding this comment.
I don't think we should leak better-sqlite3 here. I'll re-export the type that we need from packages/db.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted out functions to silently delete assets and to update them after crawling
Generalized the mapping of assets to bookmark fields to make extending them easier