Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add healthecheck api endpoint #332

Merged
merged 3 commits into from
Sep 21, 2024
Merged

add healthecheck api endpoint #332

merged 3 commits into from
Sep 21, 2024

Conversation

wuast94
Copy link
Contributor

@wuast94 wuast94 commented Jul 28, 2024

Hopefully i did all right.

Checked functionality locally.

was quite hard to find out how to disable the hooks (ESlint checking failed)

Copy link
Collaborator

@MohamedBassem MohamedBassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wuast94, I'm really sorry it took me that long to get to this PR. Thanks a lot for taking the time to implement it. I'd understand if you no longer have time to address the requested feedback :)

apps/web/app/api/health/route.ts Outdated Show resolved Hide resolved
@wuast94
Copy link
Contributor Author

wuast94 commented Sep 18, 2024

Hey @wuast94, I'm really sorry it took me that long to get to this PR. Thanks a lot for taking the time to implement it. I'd understand if you no longer have time to address the requested feedback :)

Didnt see it sry 😅 The healthcheck gets very simple then because its just the response if i didnt miss anything.

@MohamedBassem
Copy link
Collaborator

@wuast94 yeah, the healthcheck is mostly making sure that the web server is up and running.

@wuast94
Copy link
Contributor Author

wuast94 commented Sep 19, 2024

dont know why i left the variable in there but you are right on this, good catch 😊 maybe because im not a programmer xD

@MohamedBassem MohamedBassem merged commit 3377969 into hoarder-app:main Sep 21, 2024
3 checks passed
@MohamedBassem
Copy link
Collaborator

Thanks @wuast94!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants