Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueueingConsumer class is deprecated and might be replaced #45

Open
MichaelRoeder opened this issue Jan 17, 2019 · 3 comments
Open

QueueingConsumer class is deprecated and might be replaced #45

MichaelRoeder opened this issue Jan 17, 2019 · 3 comments
Labels
SHK The task has a difficulty which can be handled by a student developer

Comments

@MichaelRoeder
Copy link
Contributor

MichaelRoeder commented Jan 17, 2019

Description

The RabbitMQ client class QueueingConsumer used in our implementation is marked deprecated in favor of a the DefaultConsumer implementation (see https://github.com/rabbitmq/rabbitmq-java-client/blob/v4.8.0/src/main/java/com/rabbitmq/client/QueueingConsumer.java#L64-L92). It might be necessary to replace the implementation in the future since deprecated classes can be removed from projects.

This mainly affects the classes

@MichaelRoeder MichaelRoeder added the SHK The task has a difficulty which can be handled by a student developer label Oct 18, 2019
altafhusen-mr added a commit to melissadas/core that referenced this issue Nov 8, 2019
@sourabhpoddar404
Copy link
Contributor

Create a custom class CustomConsumer which extends DefaultConsumer class and override the method handleDelivery to add each delivery to a public class variable LinkedBlockingQueue deliveryQueue. Which will be used to fetch deliveries.

altafhusen-mr added a commit to melissadas/core that referenced this issue Nov 10, 2019
@MichaelRoeder
Copy link
Contributor Author

@sourabhpoddar404 and @altafhusen-mr Please do not simply make the queue attribute public. Try to abide to the ideas of object-oriented programming by keeping the queue private (or at least protected) and enable access by offering methods which allow only the necessary methods.

@altafhusen-mr
Copy link
Contributor

Sure @MichaelRoeder we'll update it accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SHK The task has a difficulty which can be handled by a student developer
Projects
None yet
Development

No branches or pull requests

3 participants