Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(takeUntil): change notifier type to Flow<Any?> #112

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Conversation

hoc081098
Copy link
Owner

@hoc081098 hoc081098 commented Jul 14, 2022

Status

READY

Breaking Changes

NO

Description

refactor(takeUntil): change notifier type to Flow<Any?>

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Requirements

  • Dump api
  • Update README
  • Update CHANGELOG
  • Add tests
  • Add docs

@hoc081098 hoc081098 changed the title Flow<*> refactor(takeUntil): change notifier type to Flow<Any?> Jul 15, 2022
@hoc081098 hoc081098 added this to the 0.4.0 milestone Jul 15, 2022
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #112 (370aa42) into master (dbba205) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   83.68%   83.68%           
=======================================
  Files          26       26           
  Lines         423      423           
  Branches       68       68           
=======================================
  Hits          354      354           
  Misses         46       46           
  Partials       23       23           
Impacted Files Coverage Δ
...mmonMain/kotlin/com/hoc081098/flowext/takeUntil.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbba205...370aa42. Read the comment docs.

@hoc081098 hoc081098 merged commit 99c375d into master Jul 15, 2022
@hoc081098 hoc081098 deleted the wip branch July 15, 2022 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant