Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use call instead of apply #4

Merged
merged 2 commits into from
Aug 16, 2024
Merged

use call instead of apply #4

merged 2 commits into from
Aug 16, 2024

Conversation

rbndg
Copy link
Contributor

@rbndg rbndg commented Aug 16, 2024

No description provided.

mafintosh
mafintosh reviewed Aug 16, 2024
View reviewed changes
index.js Outdated Show resolved Hide resolved
@rbndg rbndg changed the title use [] for apply use call instead of apply Aug 16, 2024
kasperisager
kasperisager approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@kasperisager kasperisager left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, .call() and .apply() indeed got mixed up!

@kasperisager kasperisager merged commit d6c318c into holepunchto:main Aug 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafintosh mafintosh mafintosh left review comments

@kasperisager kasperisager kasperisager approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbndg @mafintosh @kasperisager