rocksdb: commit overwrites full state #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chm-diederichs
force-pushed
the
rocksdb-commit-updates-dependency
branch
from
31cdf36 to
d418634
Compare
|
depends on holepunchto/hypercore-storage#26 |
mafintosh
approved these changes
Oct 19, 2024
chm-diederichs
changed the title
mafintosh
reviewed
Nov 12, 2024
lib/bit-interlude.js
Outdated
| let remove = 1 | ||
|
|
||
| if (lower.start < lower.end) this.ranges.splice(i++, remove--, lower) | ||
| this.ranges.splice(i++, remove, { start, end, value }) |
There was a problem hiding this comment.
the ++ is sus to me, we use i again below but normally you'd i-- it as you are removing from the array
There was a problem hiding this comment.
only one of them removes from the array, but they all add to it, so it ends up being:
arr = [0]
arr.splice(i++, 1, 1)
arr.splice(i++, 0, 2)
arr.splice(i, 0, 3)
// arr === [1, 2, 3]
mafintosh
reviewed
Nov 12, 2024
lib/bit-interlude.js
Outdated
| const last = (page.index + 1) * (buf.byteLength << 3) | ||
| const offset = page.index * buf.byteLength << 3 | ||
| const last = (pageIndex + 1) * (buf.byteLength << 3) | ||
| const offset = pageIndex * buf.byteLength << 3 |
There was a problem hiding this comment.
add parens around the buf.. << 3 part
mafintosh
reviewed
Nov 12, 2024
lib/core.js
Outdated
| const promises = [] | ||
| if (this.verifier === null) { | ||
| throw INVALID_OPERATION('Cannot commit without manifest') // easier to assert than upsert | ||
| } else if (this.tree.length < length && !signature) { |
There was a problem hiding this comment.
remove else, just two ifs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.