Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose user data stream from lib/core.js #604

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Expose user data stream from lib/core.js #604

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
883812b
expose user data stream from lib/core.js
chm-diederichs Nov 27, 2024
f5d70d2
enclose ternary condition
chm-diederichs Nov 28, 2024
3ea1ece
add user data stream tests
chm-diederichs Nov 28, 2024
fde069a
rename to createUserDataStream
chm-diederichs Nov 28, 2024
58d7357
clean up test
chm-diederichs Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,11 @@ module.exports = class Core {
}
}

getUserDataStream (opts) {
const storage = opts && opts.session ? opts.session.state.storage : this.storage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put a paran around the (opts && opts.session) ? always have a hard time understand what wins with these

return storage.createUserDataStream(opts)
}

allSessions () {
const sessions = []
for (const state of this.sessionStates) sessions.push(...state.sessions)
Expand Down