Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve worker desktop #478

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

improve worker desktop #478

wants to merge 1 commit into from

Conversation

maidh91
Copy link
Contributor

@maidh91 maidh91 commented Dec 4, 2024

Issue

  • Run ./pear.dev run -d ./examples/desktop
  • Then in browser console, run Pear.worker.run('pear://doctor')
  • Now,
    • case 1: if Ctrl C => both desktop apps closed
    • case 2: if we manual close examples/desktop app, doctor does not close

Summary

This PR handles the case 2 to close all child workers when the parent closes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmarkclements davidmarkclements Awaiting requested review from davidmarkclements

@rafapaezbas rafapaezbas Awaiting requested review from rafapaezbas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maidh91