Fill implementation #61

[OlivierCavadenti]

• Implements the fill function.
• Like in https://tidyr.tidyverse.org/reference/fill.html you can fill values down, up, updown, downup.
• I add a functionality from https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.fillna.html : you can fill holes with a given value (not the last value) or a dataframe (pick a value at the same place that original value).
• Closes provide a tidyr::fill equivalent #61

[holgerbrandl]

2 questions

• Since this is not part of the core-interface, this could also live in an extension function (similar to the rest of the complementary API), couldn't it?
• Shouldn't we better use vararg columSelects: ColumnSelector instead of vararg columnsToFill: String? Both for consistency with select and most other selecting methods, but also because of its enhanced functionality.

[OlivierCavadenti]

2 questions

• Since this is not part of the core-interface, this could also live in an extension function (similar to the rest of the complementary API), couldn't it?

Yes, I move it to Extensions.kt

• Shouldn't we better use vararg columSelects: ColumnSelector instead of vararg columnsToFill: String? Both for consistency with select and most other selecting methods, but also because of its enhanced functionality.

I make 2 functions with ColumnSelector and List to have both options.

[holgerbrandl]

Awesome, thanks for this wonderful contribution.

[OlivierCavadenti]

Awesome, thanks for this wonderful contribution.

No problem, I will check lately for other functionnalities to implements.