Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata and Pylint updates #374

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Metadata and Pylint updates #374

wants to merge 9 commits into from

Conversation

soulen3
Copy link
Contributor

@soulen3 soulen3 commented Mar 22, 2024

No description provided.

# Holland subcommands
[holland.commands]
#help = holland.commands.help:Help
listplugins = holland.commands.list_plugins:ListPlugins
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these help and restore sections be commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Help is done through argparser, and restore was experimental.

@ed-velez
Copy link
Contributor

Sorry for the delay in following up on this - got pulled away having to look at other things.

This should all be fine but gonna hold off merging this until we tag another release. Largely because I think we may want to introduce the pyproject.toml files across all the plugins as well vs having it added just for core holland (Unless we need that for packaging a new version - let me know!).

@soulen3
Copy link
Contributor Author

soulen3 commented May 20, 2024

I'm ok with waiting on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants