## #43: Prevent players from swimming up waterfalls #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Problem] Players can swim up waterfalls in areas where we want waterfalls as decoration but also need to restrict access. [Solution] Well there is none so far, since we tested and setting a player's hunger to 6 or lower does not work, since it is not implemented in Minestom to stop players from swimming or sprinting in this state. Also added some comments about potential structuring of handling these types of events when we have a solution.
GreatWyrm
suggested changes
Sep 24, 2022
| event.getSpawnInstance().setBlock(5, 43, 5, Ore.fromNamespaceId("unnamed:gold_ore").asBlock()); | ||
| event.getSpawnInstance().setBlock(4, 43, 5, Ore.fromNamespaceId("unnamed:diamond_ore").asBlock()); | ||
| player.getInventory().addItemStack(Item.fromNamespaceId("unnamed:diamond_pickaxe").asItemStack()); | ||
| event.getSpawnInstance().setBlock(5, 43, 5, Ore.fromNamespaceId("starlight:gold_ore").asBlock()); |
There was a problem hiding this comment.
I would remove these changes, as I am making this change in a separate PR.
| import net.minestom.server.instance.block.Block; | ||
| import org.jetbrains.annotations.NotNull; | ||
|
|
||
| public class PlayerBubbleColumnSinkEvent implements PlayerInstanceEvent { |
There was a problem hiding this comment.
Unsure if an event is strictly necessary right now. It may be useful in the future, but I'm uncertain if it needs to be included here.
modules/player/src/main/java/net/hollowcube/player/PlayerImpl.java
Outdated
Show resolved
Hide resolved
[Problem] Players can swim up waterfalls in areas where we want waterfalls as decoration but also need to restrict access. [Solution] Handle player position packets by checking if they are in a bubble column, cancel their ability to sprint (fast swim) if so. [Testing] This does work partially, however there must be some discrepancy with how a user's position is tracked when they are swimming already. If you load into the given test environment, and start swimming in the normal water, then move to the bubble column, it will sometimes not cancel your swimming. We could also potentially check within a radius of the 8 blocks around the player if that's the issue. Another potential issue with this solution is players with high ping could navigate around this by not sending a position packet until they've climbed up the waterfall on client side, and then each packet gets sent and processed but won't return them to their original location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Problem]
Players can swim up waterfalls in areas where we want waterfalls as decoration but also need to restrict access.
[Solution]
Well there is none so far, since we tested and setting a player's hunger to 6 or lower does not work, since it is not implemented in Minestom to stop players from swimming or sprinting in this state.
Also added some comments about potential structuring of handling these types of events when we have a solution.