fix: don't rotate blocks with a facing=up/down #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZakShearman
changed the title
ZakShearman
changed the title
|
I believe this code is fine because it checks if the facing property != null before trying to rotate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mworzala is it ok for this to return null/empty string if the input is null/empty string? Or maybe other code was relying that this would output north to prevent some issues in that case. If so I'll need to change it to have cases for up/down instead of using the default to just return what was input.
The code currently forces north if a block is not facing north/east/south so if it is facing
upordown, it will break its state.