Skip to content

Commit

Permalink
Add helpful comments
Browse files Browse the repository at this point in the history
  • Loading branch information
holly-cummins committed Dec 17, 2024
1 parent b0edace commit 13a07fd
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ public void orderClasses(ClassOrdererContext context) {
.getClassLoader())
.distinct()
.count();

// TODO this check probably isn't enough, because if there's a mix of QuarkusMain and other tests, we will have more than one classloader, but the others will still need sorting
if (classloaderCount > 1) {

// If we sort first before applying the classloader sorting, the original order will be preserved within classloader groups
Expand Down Expand Up @@ -152,6 +154,8 @@ private void orderByProfiles(ClassOrdererContext context) {
.map(TestProfile::value)
.map(profileClass -> prefixQuarkusTestWithProfile + profileClass.getName() + "@" + secondaryOrderSuffix)
.orElseGet(() -> {
// TODO it should be possible to re-use the resource key here for (a) less code and (b) guaranteed consistency
// TODO we should probably also extend the key logic to a profile key ?
var prefix = hasRestrictedResource(classDescriptor)
? prefixQuarkusTestWithRestrictedResource
: prefixQuarkusTest;
Expand Down

0 comments on commit 13a07fd

Please sign in to comment.