[yang3] into_raw for Bindings
#21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing CI tests are unrelated to this PR and are fixed in #24. |
rwestphal
reviewed
Dec 6, 2024
There was a problem hiding this comment.
Thanks for the contribution. Please see the inline review comments.
Overall, some yang-rs types own data, while others are simple references. So the semantics of into_raw isn't always clear, for some types as_raw would be more appropriate. We could potentially implement either into_raw or as_raw directly on the types instead of having the into_raw trait method. What do you think?
Seems reasonable to me. I had a feeling that this wasn't quite right, but had to start somewhere. I'll try to figure out where to implement |
yodaldevoid
force-pushed
the
to_raw
branch
2 times, most recently
from
58669cf to
6b06826
Compare
rwestphal
reviewed
Dec 10, 2024
Adds methods to get the raw pointer to the libyang structures held by many structures. into_raw has been implemented where the struct manages the pointer (has a Drop impl to free/release the internal struture), and as_raw has been implemented where the struct is just a wrapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
Bindings::into_rawto allow turning anyBindinginto its raw pointer.I need this as I am modifying
sysrepo-rsto remove alllibyangbindings, replacing them with the ones from this crate.