Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Add pip as an explicit dependency #94

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spencermathews
Copy link

@spencermathews spencermathews commented Aug 14, 2019

Creating the earthml conda enviroment according to the installation instructions leads to a warning related to pip:

$ conda env create -f environment.yml
Warning: you have pip-installed dependencies in your environment file, but you do not list pip itself as one of your conda dependencies.  Conda may not use the correct pip to install your packages, and they may end up in the wrong place.  Please add an explicit pip dependency.  I'm adding one for you, but still nagging you.

Including pip in the environment prevents this warning, avoids any ambiguity surrounding pip dependencies, and conforms to the best practices as I interpret them.

Copy link
Collaborator

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this should be merged, but it looks like the environment needs to be fixed first, so that tests will pass again. @jsignell may be able to get to that next week...

@spencermathews
Copy link
Author

What's up with those checks anyway? And why should they fail due to such an innocuous change?

@jbednar
Copy link
Collaborator

jbednar commented Aug 14, 2019

It's presumably due to one of our dependencies having released a new and slightly incompatible version; nothing to do with your change. Any new PR opened now will probably show the same problem...

@jsignell jsignell self-assigned this Aug 27, 2019
@jsignell jsignell removed their assignment Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants