Fix antialiased line divide by zero bug #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1099 +/- ##
==========================================
+ Coverage 85.05% 85.07% +0.01%
==========================================
Files 34 34
Lines 7514 7516 +2
==========================================
+ Hits 6391 6394 +3
+ Misses 1123 1122 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1098.
Solution is to disable the special treatment of
self_intersect=Truein line segments for which the start segment point is the same as the previous duplicate point. Theself_intersectwould do nothing in this situation anyway so avoiding it does not affect the output produced and prevents the divide by zero.