Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure cuda functions are correctly jitted #1153

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Ensure cuda functions are correctly jitted #1153

merged 1 commit into from
Dec 7, 2022

Conversation

ianthomas23
Copy link
Member

Some of the recently introduced CUDA _append functions in reduction.py were using standard numba jitting not cuda-backed jitting. This PR fixes them.

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #1153 (6858a3a) into master (b69aaef) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1153   +/-   ##
=======================================
  Coverage   85.37%   85.37%           
=======================================
  Files          34       34           
  Lines        7782     7782           
=======================================
  Hits         6644     6644           
  Misses       1138     1138           
Impacted Files Coverage Δ
datashader/reductions.py 87.23% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ianthomas23 ianthomas23 merged commit 38afcc7 into holoviz:master Dec 7, 2022
@ianthomas23 ianthomas23 deleted the cuda_jitted_functions branch December 7, 2022 16:56
@ianthomas23 ianthomas23 added this to the v0.14.4 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants