Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cuda arg to _build_combine #1194

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Add cuda arg to _build_combine #1194

merged 1 commit into from
Mar 20, 2023

Conversation

ianthomas23
Copy link
Member

This PR adds a new boolean cuda argument to the Reduction._build_combine function. This function (overridden in derived classes) returns a function that is used to combine the aggregations of multiple dask partitions.

There is no change in functionality here, just a simplification of where._build_combine which is currently the only code that has different combine behaviour depending of whether the calculations are occurring on the CPU or GPU. But the change is required for the upcoming CUDA mutex PRs which behave differently depending on the new cuda argument.

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #1194 (8f822cc) into main (206e8c6) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1194   +/-   ##
=======================================
  Coverage   85.48%   85.48%           
=======================================
  Files          35       35           
  Lines        8232     8232           
=======================================
  Hits         7037     7037           
  Misses       1195     1195           
Impacted Files Coverage Δ
datashader/compiler.py 95.74% <100.00%> (ø)
datashader/reductions.py 86.17% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ianthomas23 ianthomas23 merged commit ed0d58e into holoviz:main Mar 20, 2023
@ianthomas23 ianthomas23 deleted the build_combine_cuda_arg branch March 20, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant