Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support by reduction within summary reduction #1254

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Support by reduction within summary reduction #1254

merged 2 commits into from
Jul 24, 2023

Conversation

ianthomas23
Copy link
Member

Fixes #1252, allowing use of by reduction within a summary reduction such as

ds.summary(other=ds.by("cat"))`

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #1254 (e4bcb0d) into main (7bff9b4) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1254      +/-   ##
==========================================
+ Coverage   83.42%   83.44%   +0.02%     
==========================================
  Files          35       35              
  Lines        8869     8882      +13     
==========================================
+ Hits         7399     7412      +13     
  Misses       1470     1470              
Impacted Files Coverage Δ
datashader/compiler.py 88.38% <100.00%> (+0.05%) ⬆️
datashader/reductions.py 78.06% <100.00%> (+0.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ianthomas23 ianthomas23 merged commit 4a1c3fc into holoviz:main Jul 24, 2023
16 checks passed
@ianthomas23 ianthomas23 deleted the 1252_by_within_summary branch July 24, 2023 11:25
@ianthomas23 ianthomas23 added this to the v0.15.2 milestone Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use by reduction within a summary reduction
1 participant