Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of
*_n
reductions such asmax_n
so that all shift and insert functionality is in a singleshift_and_insert
function rather than repeated across the codebase. The new function takes a 1D array of lengthn
(then
of themax_n
or similar), thevalue
to insert and theindex
to insert at. The function shifts alongs values fromindex
onwards one along the array and inserts thevalue
.This is CPU only, GPU equivalent will follow in a separate PR.