Implement lines using 2D xarray with common x coordinates #1282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress to implement datashading lines from a 2D xarray that has common
x
coordinates, as described in issue #1278.So far it only works for
count
andany
reductions, with and without Dask but only on the CPU not GPU. Further work is underway to support other simple reductions, categorical andwhere
reductions, antialiasing, CUDA, etc.There is a limitation when using dask chunking of the 2D array in the
x
direction in that the line segments between chunks are not rendered. This is the same limitation that occurs in other datashader line glyphs that similarly chunk along arrays, and no attempt will be made to address the limitation in this PR.This work is part of a CZI Round 5 grant.