Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use object as base class #1286

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Don't use object as base class #1286

merged 1 commit into from
Oct 6, 2023

Conversation

ianthomas23
Copy link
Member

Don't use object as base class, it is unnecessary.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #1286 (d617e59) into main (1c5df74) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1286   +/-   ##
=======================================
  Coverage   85.74%   85.74%           
=======================================
  Files          52       52           
  Lines       10870    10870           
=======================================
  Hits         9320     9320           
  Misses       1550     1550           
Files Coverage Δ
datashader/bundling.py 98.64% <100.00%> (ø)
datashader/core.py 88.25% <100.00%> (ø)
datashader/datashape/coretypes.py 98.93% <100.00%> (ø)
datashader/datashape/internal_utils.py 97.67% <100.00%> (ø)
datashader/datashape/parser.py 97.93% <100.00%> (ø)
datashader/datashape/type_symbol_table.py 100.00% <100.00%> (ø)
datashader/datashape/typesets.py 98.85% <100.00%> (ø)
datashader/datatypes.py 93.75% <100.00%> (ø)
datashader/glyphs/line.py 93.16% <100.00%> (ø)
datashader/pipeline.py 100.00% <100.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ianthomas23 ianthomas23 merged commit 95fa9e8 into holoviz:main Oct 6, 2023
16 checks passed
@ianthomas23 ianthomas23 deleted the no_object_base_class branch October 6, 2023 09:39
@ianthomas23 ianthomas23 added this to the v0.15.3 milestone Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant