Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codecov configuration #1292

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Update codecov configuration #1292

merged 1 commit into from
Oct 18, 2023

Conversation

ianthomas23
Copy link
Member

Update codecov configuration so that reporting is more informative, and allow a slight reduction in coverage to still be classified as passing, otherwise PRs that update CUDA code will always be reported as failing coverage changes as CUDA code is not exercised by our Github Actions.

@ianthomas23
Copy link
Member Author

Closes #1274.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #1292 (7974085) into main (ebae7d0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1292   +/-   ##
=======================================
  Coverage   85.77%   85.77%           
=======================================
  Files          52       52           
  Lines       10974    10974           
=======================================
  Hits         9413     9413           
  Misses       1561     1561           

@ianthomas23
Copy link
Member Author

This improves the situation so merging.

@ianthomas23 ianthomas23 reopened this Oct 18, 2023
@ianthomas23 ianthomas23 merged commit cb0ca17 into main Oct 18, 2023
15 checks passed
@ianthomas23 ianthomas23 deleted the codecov branch October 18, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant