Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify line _internal_build_extend #1294

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Simplify line _internal_build_extend #1294

merged 1 commit into from
Oct 19, 2023

Conversation

ianthomas23
Copy link
Member

Refactor of the 7 line glyph classes to move common functionality from the various _internal_build_extend functions to a common _line_internal_build_extend.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1294 (f176f11) into main (cb0ca17) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1294      +/-   ##
==========================================
- Coverage   85.77%   85.74%   -0.04%     
==========================================
  Files          52       52              
  Lines       10974    10947      -27     
==========================================
- Hits         9413     9386      -27     
  Misses       1561     1561              

@ianthomas23 ianthomas23 merged commit 606f7bf into main Oct 19, 2023
13 checks passed
@ianthomas23 ianthomas23 deleted the simplify_lines branch October 19, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant