Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gpu marker and test both Classic/dask-expr Dask DataFrames #1341

Merged
merged 52 commits into from
May 30, 2024
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 23, 2024

By having it as markers it should be easy to test --gpu tests separately and not wait for the whole suite to pass. Running the non-GPU test continuously runs on the CI.

image

The classic / dask-expr was mostly something I wanted to test out if I could get to work, and was "easy" to do when the rest of the test infrastructure was updated.

@hoxbro hoxbro changed the title Parallelize the test suite Add gpu marker May 23, 2024
@hoxbro hoxbro changed the title Add gpu marker POC: Add gpu marker May 23, 2024
@hoxbro hoxbro marked this pull request as draft May 23, 2024 14:28
@hoxbro hoxbro changed the title POC: Add gpu marker POC: Add gpu marker and test both Classic/dask-expr Dask DataFrames May 23, 2024
datashader/tests/conftest.py Outdated Show resolved Hide resolved
return request.param()


@pytest.fixture(params=[1, 2, 4])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason why to test for 1 to 4, so I removed 3.

@hoxbro hoxbro marked this pull request as ready for review May 24, 2024 16:17
@hoxbro hoxbro changed the title POC: Add gpu marker and test both Classic/dask-expr Dask DataFrames Add gpu marker and test both Classic/dask-expr Dask DataFrames May 28, 2024
Base automatically changed from update_test_run to main May 30, 2024 10:41
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 86.52850% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 90.31%. Comparing base (0cdbd43) to head (751095d).

Files Patch % Lines
datashader/tests/test_dask.py 78.87% 15 Missing ⚠️
datashader/tests/test_pandas.py 88.37% 5 Missing ⚠️
datashader/tests/test_transfer_functions.py 84.37% 5 Missing ⚠️
datashader/tests/test_xarray.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1341      +/-   ##
==========================================
- Coverage   90.38%   90.31%   -0.08%     
==========================================
  Files          91       92       +1     
  Lines       18764    18579     -185     
==========================================
- Hits        16960    16779     -181     
+ Misses       1804     1800       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro merged commit c6aaa77 into main May 30, 2024
15 of 16 checks passed
@hoxbro hoxbro deleted the gpu_marker branch May 30, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants