Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty indicator when groupby is set #118

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Handle empty indicator when groupby is set #118

merged 3 commits into from
Jul 2, 2024

Conversation

droumis
Copy link
Member

@droumis droumis commented Jun 27, 2024

Fixes #119

Fix error when creating a new annotation from an empty annotator overlaid on an element and when .groupby has been set

  • add tests
  • document error

Copy link

codspeed-hq bot commented Jun 27, 2024

CodSpeed Performance Report

Merging #118 will not alter performance

Comparing handle_empty (8a44fc0) with main (0e8d4e8)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.85%. Comparing base (0e8d4e8) to head (8a44fc0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   86.77%   86.85%   +0.07%     
==========================================
  Files          25       25              
  Lines        2662     2677      +15     
==========================================
+ Hits         2310     2325      +15     
  Misses        352      352              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@droumis droumis marked this pull request as ready for review July 2, 2024 17:08
@droumis droumis requested a review from hoxbro July 2, 2024 17:08
@hoxbro hoxbro merged commit 36f5602 into main Jul 2, 2024
13 checks passed
@hoxbro hoxbro deleted the handle_empty branch July 2, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error creating annotation from empty annotator, overlaid on element, and with .groupby
2 participants