Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectorizing Indicators #32

Merged
merged 26 commits into from
Sep 28, 2023
Merged

Vectorizing Indicators #32

merged 26 commits into from
Sep 28, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Sep 22, 2023

This PR does the following:

  • Implementing the new vectorized VSpans and VLines and removing the previous workarounds for it.
  • Restructuring how Indicators are called by merging region_df and field_df before passing it into an Indicator.
  • Move hover creation to indicators.
  • Update the minimum Python version to 3.9 as it is needed for Bokeh 3.2.
  • Always have the merged dataframe have the same column and type.
  • Move get_indices_by_position into Annotation Table.
  • Add basic implementation of point detection.

@hoxbro hoxbro marked this pull request as draft September 22, 2023 14:04
@hoxbro hoxbro marked this pull request as ready for review September 28, 2023 16:59
@hoxbro hoxbro merged commit 2c7442a into main Sep 28, 2023
11 checks passed
@hoxbro hoxbro deleted the vector_lines_spans branch September 28, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant