Apply suggestions from code review

holoviz · Jan 23, 2020 · 1959fad · 1959fad
1 parent aec5703
commit 1959fad
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/holoviews/element/comparison.py b/holoviews/element/comparison.py
@@ -312,8 +312,8 @@ def compare_dimensions(cls, dim1, dim2, msg=None):
                                        % (set(dim1_params.keys()), set(dim2_params.keys())))
 
         for k in dim1_params.keys():
-            if (dim1.param[k].__class__.__name__ == 'Callable'
-                and dim2.param[k].__class__.__name__ == 'Callable'):
+            if (dim1.param.objects('existing')[k].__class__.__name__ == 'Callable'
+                and dim2.param.objects('existing')[k].__class__.__name__ == 'Callable'):
                 continue
             try:  # This is needed as two lists are not compared by contents using ==
                 cls.assertEqual(dim1_params[k], dim2_params[k], msg=None)

diff --git a/holoviews/plotting/bokeh/util.py b/holoviews/plotting/bokeh/util.py
@@ -587,7 +587,7 @@ def get_tab_title(key, frame, overlay):
             title = []
             if frame.label:
                 title.append(frame.label)
-                if frame.group != frame.param['group'].default:
+                if frame.group != frame.param.objects('existing)['group'].default:
                     title.append(frame.group)
             else:
                 title.append(frame.group)