Skip to content

Commit

Permalink
Ensure Dimension clone copies all parameters (#3580)
Browse files Browse the repository at this point in the history
  • Loading branch information
philippjfr authored and jlstevens committed Mar 26, 2019
1 parent 5483be8 commit 5a3c3df
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions holoviews/core/dimension.py
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ def clone(self, spec=None, **overrides):
Returns:
Cloned Dimension object
"""
settings = dict(self.get_param_values(onlychanged=True), **overrides)
settings = dict(self.get_param_values(), **overrides)

if spec is None:
spec = (self.name, overrides.get('label', self.label))
Expand All @@ -337,7 +337,6 @@ def clone(self, spec=None, **overrides):
'Using label as supplied by keyword ({!r}), ignoring '
'tuple value {!r}'.format(overrides['label'], spec[1]))
spec = (spec[0], overrides['label'])

return self.__class__(spec, **{k:v for k,v in settings.items()
if k not in ['name', 'label']})

Expand Down

0 comments on commit 5a3c3df

Please sign in to comment.