-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable situate_axes in matplotlib for consistency #1978
Conversation
Seems fine though maybe we should have a switch in |
I'm okay adding that but afaik |
Ah okay, great. So are we just going to add new keywords to the config argument like |
We can use any keywords we want in |
That seems pretty pointless imo, how would anyone discover that keyword exists? Seems easier to just have backward compatibility notice that says you can revert to |
I do agree but if there are enough changes then they should go in a |
9b64830
to
a05d53d
Compare
a05d53d
to
60608e9
Compare
60608e9
to
9708350
Compare
I don't think this needs its own flag and I'm not aware of any other changes this could be grouped in with, so I'd prefer just to get this merged. |
Ok. Though at the very least this will need to be mentioned wrt backwards compatibility in the new CHANGELOG. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Very early on when implementing holoviews we added a
situate_axes
option which disables axis normalization for Raster and Image types in matplotlib. This pops up as a user question fairly frequently since it is inconsistent behavior.Fixes: #692