Provide control over bokeh aspect #2171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
I am optimistically assigning this to the next milestone though I believe it might require a fair bit of discussion. |
|
Closing since stale and not working, new solution will build on the layout work about to be merged into bokeh. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for exposing the
match_aspectoption in bokeh as requested in #1953. While it isn't ideal it provides at least some control over the screen vs. data space aspect. The main problem being that it doesn't work when explicitly set ranges are used, so for now it simply skips setting the holoviews computed ranges and relies on bokeh's data range calculations. This is mostly useful for plots like this #2155, which require a fixed screen vs. data range aspect ratio.