Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trisurface renamed to TriSurface #2219

Merged
merged 6 commits into from
Dec 20, 2017
Merged

Trisurface renamed to TriSurface #2219

merged 6 commits into from
Dec 20, 2017

Conversation

jlstevens
Copy link
Contributor

The branch is misnamed after deciding that TriMesh was not the inconsistent name but Trisurface was.

@jlstevens
Copy link
Contributor Author

@philippjfr Not sure there is much more to this PR other than having you check that the plotly TriSurface/Trisurface works for you (I can't test it because of some odd webgl error!)

@philippjfr
Copy link
Member

@jlstevens
Copy link
Contributor Author

Thanks..I'll fix those shortly.

@jlstevens
Copy link
Contributor Author

That should be the rest of them. Happy to merge when the tests pass?

@jlstevens
Copy link
Contributor Author

There are two failures that look like they will require the test data to be updated.

@philippjfr
Copy link
Member

There are two failures that look like they will require the test data to be updated.

Seems likely if you updated the group.

@jlstevens
Copy link
Contributor Author

I have now updated the test data.

@philippjfr
Copy link
Member

PR build passing, merging.

@philippjfr philippjfr merged commit ae8e941 into master Dec 20, 2017
philippjfr pushed a commit that referenced this pull request Feb 11, 2018
@philippjfr philippjfr added this to the 1.9.3 milestone Feb 11, 2018
@philippjfr philippjfr deleted the trimesh_rename branch February 11, 2018 17:02
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants