Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook improvements #2220

Merged
merged 3 commits into from
Jan 3, 2018
Merged

Notebook improvements #2220

merged 3 commits into from
Jan 3, 2018

Conversation

philippjfr
Copy link
Member

Various notebook improvements:

  • Added list of supported data formats to Tabular Datasets user guide
  • Fixed Plotting with Bokeh axis example
  • Added section about bokeh interactive legends to Plotting with Bokeh (as requested in Document bokeh interactive legends #1265)

@philippjfr philippjfr added the type: docs Related to the documentation and examples label Dec 20, 2017
"* 0D: BoxWhisker, Spikes, Distribution, \n",
"* 1D: Scatter, Curve, ErrorBars, Spread, Bars, BoxWhisker\n",
"* 2D: Points, HeatMap, Bars, BoxWhisker, Bivariate\n",
"* 3D: Scatter3D, Trisurface, VectorField, BoxWhisker, Bars\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should now be TriSurface.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@jlstevens
Copy link
Contributor

Looks good, other than updating the spelling to TriSurface, I am happy to merge.

@@ -244,15 +244,15 @@
"metadata": {},
"outputs": [],
"source": [
"%%opts Overlay [show_legend=False height=400 width=600] ErrorBars (line_width=5) Scatter(alpha=0.2 size=6)\n",
"%%opts Overlay [show_legend=False height=400 width=600] ErrorBars (line_width=5) Scatter [jitter=0.2] (alpha=0.2 size=6)\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking that jitter complains if it is used without categorical axes (it should)....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened an issue here: #2236

@philippjfr
Copy link
Member Author

@jlstevens Ready to merge.

@philippjfr philippjfr force-pushed the notebook_improvements branch from 54c4488 to 3382bf4 Compare January 3, 2018 12:34
@jlstevens
Copy link
Contributor

Looks good. Merging!

@jlstevens jlstevens merged commit fcdbca6 into master Jan 3, 2018
@philippjfr philippjfr deleted the notebook_improvements branch January 13, 2018 13:12
philippjfr added a commit that referenced this pull request Feb 9, 2018
@philippjfr philippjfr added this to the 1.9.3 milestone Feb 11, 2018
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: docs Related to the documentation and examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants