Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous stream fixes #2256

Merged
merged 3 commits into from
Jan 11, 2018
Merged

Miscellaneous stream fixes #2256

merged 3 commits into from
Jan 11, 2018

Conversation

philippjfr
Copy link
Member

Includes three small fixes:

  • AreaPlot no longer allows streaming data (because the glyph type doesn't allow it)
  • TablePlot initializes stream callbacks
  • When a data source is shared across multiple plots callbacks are reinitialized

@philippjfr philippjfr added type: bug Something isn't correct or isn't working tag: backend: bokeh labels Jan 11, 2018
@philippjfr
Copy link
Member Author

Ready for review/merge. All uncontroversial small fixes.

@jlstevens
Copy link
Contributor

Looks good to me. Merging.

@jlstevens jlstevens merged commit 1746f57 into master Jan 11, 2018
@ayoungs
Copy link

ayoungs commented Jan 12, 2018

InteractiveBoxTestApp.py.zip
This small test of a stream and Overlaying a bounds on an Image still doesn't work.
I thought it might be related.

@philippjfr
Copy link
Member Author

@ayoungs Are you using HoloViews master? It does work for me.

@ayoungs
Copy link

ayoungs commented Jan 12, 2018

Now I have it working, using the correct install process and it works as expected! Thank you!

@philippjfr
Copy link
Member Author

We'll have to have a 1.9.3 bug fix release asap.

@philippjfr philippjfr deleted the misc_streams_fixes branch January 13, 2018 13:12
philippjfr added a commit that referenced this pull request Feb 9, 2018
@philippjfr philippjfr added this to the 1.9.3 milestone Feb 11, 2018
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tag: backend: bokeh type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants