Pass operation to Operation hooks #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good and the tests are green. It would be an API change if libraries other than geoviews were using this mechanism but I am fairly sure this only affects geoviews. Merging. |
|
Right, this "feature" hasn't been in a release yet so technically it's not an API change. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we added hooks to operations which could do some pre- and post-processing on the data. The current implementation only passes the unprocessed and processed objects to the pre- and post-hook respectively when it would be more general if it also passed in the operation. This can be useful e.g. to apply pre-processing the operation parameters. The specific use-case I have in mind is ensuring that GeoViews returns RangeXY stream bounds in the correct coordinate system.