Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for datetime streaming bug in bokeh #2383

Merged
merged 2 commits into from
Mar 12, 2018
Merged

Workaround for datetime streaming bug in bokeh #2383

merged 2 commits into from
Mar 12, 2018

Conversation

philippjfr
Copy link
Member

Very ugly workaround for bokeh/bokeh#7587 in bokeh datetime streaming.

@philippjfr philippjfr added type: bug Something isn't correct or isn't working tag: backend: bokeh labels Mar 1, 2018
@philippjfr philippjfr force-pushed the datetime_bokeh_bug branch from 4490594 to 3dd2e32 Compare March 1, 2018 16:29
@stonebig
Copy link
Contributor

stonebig commented Mar 1, 2018

so my code with bokeh-0.12.5.dev1 will break also ? would it be possible to include it in the test ?

@philippjfr
Copy link
Member Author

so my code with bokeh-0.12.5.dev1 will break also ? would it be possible to include it in the test ?

Probably a good idea.

@philippjfr philippjfr force-pushed the datetime_bokeh_bug branch from 3dd2e32 to ba377db Compare March 1, 2018 16:34
@philippjfr philippjfr force-pushed the datetime_bokeh_bug branch from ba377db to 86b886c Compare March 2, 2018 00:06
@philippjfr
Copy link
Member Author

Ready to merge.

@philippjfr
Copy link
Member Author

Looks like this change will require pinning to bokeh>=0.12.14, which also affects 1.9.5 since I ported this change there.

@jlstevens
Copy link
Contributor

Looks like this change will require pinning to bokeh>=0.12.14...

Are you going to pin bokeh in this PR? I would also like to see an issue to remove this hack once it is fixed in bokeh to make sure we remove this code when we can.

Otherwise, happy to merge.

@philippjfr
Copy link
Member Author

philippjfr commented Mar 6, 2018 •
edited
Loading

I would also like to see an issue to remove this hack once it is fixed in bokeh to make sure we remove this code when we can.

Unless we want to remove support for bokeh 0.12.14 we can't really delete this. But I'll pin bokeh now.

@jlstevens
Copy link
Contributor

Unless we want to remove support for bokeh 0.12.14 we can't really delete this.

We will be happy to remove support for bokeh 0.12.14 eventually so I would still file an issue. Maybe assign it to the 2.0 milestone.

@philippjfr philippjfr mentioned this pull request Mar 8, 2018
Closed
@jlstevens
Copy link
Contributor

Looks good. Merging.

@jlstevens jlstevens merged commit d983551 into master Mar 12, 2018
@philippjfr philippjfr deleted the datetime_bokeh_bug branch March 14, 2018 04:11
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
tag: backend: bokeh type: bug Something isn't correct or isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philippjfr @stonebig @jlstevens