Updated to latest pyviz_comms version #2977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
force-pushed
the
pyviz_comms_cleanup
branch
from
05f4636 to
c380452
Compare
jlstevens
reviewed
Sep 3, 2018
| @@ -237,6 +238,12 @@ def load_hvjs(cls, logo=False, bokeh_logo=False, mpl_logo=False, plotly_logo=Fal | |||
| widgetjs, widgetcss = Renderer.html_assets(extras=False, backends=[], script=True) | |||
| else: | |||
| widgetjs, widgetcss = '', '' | |||
|
|
|||
| # Add classic notebook MIME renderer | |||
There was a problem hiding this comment.
I do prefer to have a .js file in pyviz_comms but there is no reason pyviz_comms couldn't read in that file there and expose the string instead of having downstream projects repeat this code over and over. i.e something like from pyviz_comms import widget_js.
|
A new version of |
|
Tests have passed. Merging. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various updates for use with pyviz_comms 0.1.2
Get classic notebook MIME renderer from pyviz_comms
Get embed_js code from pyviz_comms
Close comms on cleanup
Pin pyviz_comms 0.6.0 (once released)