-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color bar limit opt and redim range if values are equal. #3382
Merged
+30
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
reviewed
Jan 12, 2019
philippjfr
reviewed
Jan 12, 2019
ahuang11
changed the title
Add image warnings
Add color bar limit opt and redim range if values are equal.
Jan 13, 2019
Closed
philippjfr
reviewed
Jan 14, 2019
philippjfr
reviewed
Jan 14, 2019
philippjfr
reviewed
Jan 15, 2019
Thanks it's looking good, I'll handle the rebasing once the other PR is merged. |
philippjfr
force-pushed
the
add_image_warnings
branch
from
January 15, 2019 03:18
81bc431
to
5c2080d
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3373 and #3350 and isn't in the same PR as #3381 because I wasn't sure if the extra computations are worth it for the warnings.