Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated tests after changes in param formatting #3591

Merged
merged 2 commits into from
Mar 31, 2019

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 30, 2019

This PR updates tests to match the changed formatting in the latest param dev release. While it fixes the test errors the param change also revealed the fact that the tests seem to have suppressed warnings entirely in the past, which is no longer the case now. We should work on either fixing the warning or suppress them where needed but that can happen in a subsequent PR.

@philippjfr philippjfr merged commit 6de071a into master Mar 31, 2019
@philippjfr philippjfr deleted the update_param_warn_tests branch April 29, 2019 11:24
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant