Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only merge changed instance params with rasterize #5767

Merged
merged 5 commits into from
Jun 20, 2023
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jun 18, 2023

Supersedes #5351
Fixes #5358

rasterize has expand=True as default, whereas regrid has it as expand=False. When applying all the parameters from the rasterize class, regrid was set to have expand=True.

This change makes it so only non-default values are used.

@hoxbro hoxbro changed the title Only merge non_default_params Only merge non default params in rasterize Jun 18, 2023
@hoxbro hoxbro changed the title Only merge non default params in rasterize Only merge non-default params with rasterize Jun 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2023

Codecov Report

Merging #5767 (597cef1) into main (14d7d9d) will decrease coverage by 0.01%.
The diff coverage is 75.86%.

@@            Coverage Diff             @@
##             main    #5767      +/-   ##
==========================================
- Coverage   88.18%   88.17%   -0.01%     
==========================================
  Files         306      306              
  Lines       62739    62767      +28     
==========================================
+ Hits        55326    55346      +20     
- Misses       7413     7421       +8     
Impacted Files Coverage Δ
holoviews/core/util.py 86.05% <12.50%> (-0.48%) ⬇️
holoviews/operation/datashader.py 83.22% <100.00%> (+0.01%) ⬆️
holoviews/tests/operation/test_datashader.py 97.41% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

holoviews/core/util.py Outdated Show resolved Hide resolved
hoxbro and others added 2 commits June 19, 2023 13:58
Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>
@hoxbro hoxbro changed the title Only merge non-default params with rasterize Only merge changed instance params with rasterize Jun 20, 2023
@hoxbro hoxbro requested a review from philippjfr June 20, 2023 06:41
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hoxbro hoxbro merged commit 68e87da into main Jun 20, 2023
@hoxbro hoxbro deleted the rasterize_image_expand2 branch June 20, 2023 10:19
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In this example, OSM Tiles look great, then disappear!
3 participants