-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only merge changed instance params with rasterize #5767
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5767 +/- ##
==========================================
- Coverage 88.18% 88.17% -0.01%
==========================================
Files 306 306
Lines 62739 62767 +28
==========================================
+ Hits 55326 55346 +20
- Misses 7413 7421 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Supersedes #5351
Fixes #5358
rasterize
hasexpand=True
as default, whereasregrid
has it asexpand=False
. When applying all the parameters from the rasterize class,regrid
was set to haveexpand=True
.This change makes it so only non-default values are used.